[libcxx-commits] [PATCH] D120634: [Libcxx] Add <source_location> header.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.

LGTM % nits with green CI assuming you didn't change much about the implementation. I only looked through it quickly. There might be some tooling failing since we've added quite a bit in the last few months. Although I didn't notice while looking through the patch.



================
Comment at: libcxx/include/source_location:38
+
+#if _LIBCPP_STD_VER > 17 && __has_builtin(__builtin_source_location)
+
----------------
We switched to using this style a few months ago.


================
Comment at: libcxx/test/std/language.support/support.srcloc/general.pass.cpp:10-11
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: clang-12, clang-13, clang-14, clang-15
+// UNSUPPORTED: apple-clang-12, apple-clang-13, apple-clang-14
+
----------------
We only support these compilers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120634/new/

https://reviews.llvm.org/D120634