[libcxx-commits] [PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added subscribers: fahad, rprichard, MaskRay.
ldionne added a comment.

The code in libunwind does look fishy to me (before the change), so I think flagging this in the compiler is good. I don't know that code at all, though, so I'm pinging a few libunwind regulars so they can let us know what they think. FWIW it looks reasonable to me. @rprichard @MaskRay

You probably also want to rebase your patch on top of `main` -- the failures you are seeing right now seem to be spurious issues.

@aaron.ballman When libunwind is changed, the CI now only triggers the usual libc++ pipeline even though Clang was changed too. I'll look into fixing that. @fahad that's unrelated to your patch, just for information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139114/new/

https://reviews.llvm.org/D139114