[libcxx-commits] [PATCH] D141184: [libc++] Fix aligned_alloc usage for Android

Tue Jan 10 11:26:40 PST 2023

rprichard added a comment.

In D141184#4039656 <https://reviews.llvm.org/D141184#4039656>, @smeenai wrote:

> In D141184#4033243 <https://reviews.llvm.org/D141184#4033243>, @philnik wrote:
>
>> LGTM assuming D139147 <https://reviews.llvm.org/D139147> is being worked on.
>
> I'm not involved with that effort directly (I work on Meta's Android compiler team, whereas @rprichard is on the Android NDK team at Google), but I understand wanting a buildbot to test this configuration. I can't speak on his behalf, but I trust that Ryan will work on that actively once holiday season is wrapped up.

Yeah I'll be resuming work on that soon.

The D139147 <https://reviews.llvm.org/D139147> configuration currently only tests a configuration where libc++ is built against API21 and run on an API33 emulator. I think(?) that would be sufficient to catch this issue because the API21 headers and libc.so stub wouldn't have an aligned_alloc function? The emulator image would have one in its /system/lib64/libc.so though.

This change looks OK to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141184/new/

https://reviews.llvm.org/D141184