[libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 10 10:40:58 PST 2023

Previous message: [libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function
Next message: [libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

ldionne added a comment.

LGTM, the CI failure is a flake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141388/new/

https://reviews.llvm.org/D141388

Previous message: [libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function
Next message: [libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the libcxx-commits mailing list