[libcxx-commits] [PATCH] D141321: [libc++] Add [[clang::lifetimebound]] attribute to std::forward and friends

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added subscribers: aaron.ballman, rnk, rsmith.
ldionne added a comment.

Thanks! This is a nice improvement IMO.

However, the CI issue you're seeing is actually a very interesting and slightly deeper issue. Indeed, remember when Clang decided to define `forward` and `move` as builtins in D123345 <https://reviews.llvm.org/D123345>? One impact of that change is that we don't control our `std::forward` and `std::move` anymore, so we'd need to make the change in this patch inside Clang, not inside libc++. An obvious follow-up question is then do we make the change in Clang and strive to keep libc++ in synchronization with how Clang defines `std::forward`? Or do we not care about keeping them in sync? Should we have a way to ensure that both definitions stay in sync?

CC Clang folks @rnk @rsmith @aaron.ballman


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141321/new/

https://reviews.llvm.org/D141321