[libcxx-commits] [PATCH] D108697: [libc++] Remove <experimental/coroutine>

[Aaron Ballman via Phabricator via libcxx-commits]

aaron.ballman added a comment.

In D108697#4040079 <https://reviews.llvm.org/D108697#4040079>, @ldionne wrote:

> @aaron.ballman I seem to recall that we had spoken about delaying this for one more release while Clang was deprecating its `-fcoroutines-ts` flag. Do you remember that or did the holidays mess with my brain?
>
> Otherwise, I guess the next step here would be to post an announcement on Discourse and land this -- but I think it makes sense to coordinate with Clang since that will essentially break the `-fcoroutines-ts` flag.

We talked about removing `-fcoroutines-ts` for Clang 16 in https://github.com/llvm/llvm-project/issues/59110, but we didn't really talk about the experimental header except to say that some folks want to set the expectation experimental headers can be removed at any time. Personally, I think we want to be more user-friendly and give users at least a one release window to react to changes (this makes upgrading versions of Clang a bit easier because the problem to be fixed isn't a stop-the-world issue that prevents you from finding further surprises). To me, that should apply to command line flags as well as header files because removing either one causes a stop-the-world problem. Would it make sense to have one libc++ release with a deprecation warning when you include the header along with the command line flag deprecation warning? Or are you ready to be done with this header? :-)

(Speaking of the command line flag deprecation warning, is that something you're working on @ChuanqiXu? If not, I can put something together pretty quickly before the Clang 16 branch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108697/new/

https://reviews.llvm.org/D108697