[libcxx-commits] [PATCH] D140911: [libc++] Implement P2505R5(Monadic operations for std::expected)

[Yurong via Phabricator via libcxx-commits]

yronglin added inline comments.


================
Comment at: libcxx/test/std/utilities/expected/expected.expected/monadic/and_then.pass.cpp:163
+
+// clang-format off
+constexpr void test_val_types() {
----------------
yronglin wrote:
> philnik wrote:
> > Mordante wrote:
> > > We don't require clang-format, so I have a slight preference to remove this.
> > I'd keep it, since it allows you to clang-format the file if you change anything. I actually do this for the files which look formatted regularly.
> Yes, this was added in the past to facilitate formatting files, otherwise the format here will be disrupted by `clang-format`, I can keep these if you guys agree
If we remove `// clang-format off ......// clang-format on.... `, the code here will be formatted in a very strange format(I've used vscode `Format Document`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140911/new/

https://reviews.llvm.org/D140911