[libcxx-commits] [PATCH] D140911: [libc++] Implement P2505R5(Monadic operations for std::expected)

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 10 08:49:45 PST 2023


philnik added inline comments.


================
Comment at: libcxx/test/std/utilities/expected/expected.expected/monadic/and_then.pass.cpp:163
+
+// clang-format off
+constexpr void test_val_types() {
----------------
Mordante wrote:
> We don't require clang-format, so I have a slight preference to remove this.
I'd keep it, since it allows you to clang-format the file if you change anything. I actually do this for the files which look formatted regularly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140911/new/

https://reviews.llvm.org/D140911



More information about the libcxx-commits mailing list