[libcxx-commits] [PATCH] D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function

Tue Jan 10 08:40:30 PST 2023

yronglin marked an inline comment as done.
yronglin added inline comments.

================
Comment at: libcxx/include/sstream:263
                      ios_base::openmode __wch = ios_base::in | ios_base::out) override;
-    _LIBCPP_INLINE_VISIBILITY
     pos_type seekpos(pos_type __sp,
----------------
ldionne wrote:
> This should be `_LIBCPP_HIDE_FROM_ABI_VIRTUAL`.
Thanks for your comments @ldionne  I've updated this patch

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141388/new/

https://reviews.llvm.org/D141388