[libcxx-commits] [PATCH] D141388: [libc++] Remove _LIBCPP_INLINE_VISIBILITY attribute on virtual function

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 10 08:32:40 PST 2023


ldionne added a comment.

Thanks for the catch. I'm not sure why I am not able to reproduce this failure locally.



================
Comment at: libcxx/include/sstream:263
                      ios_base::openmode __wch = ios_base::in | ios_base::out) override;
-    _LIBCPP_INLINE_VISIBILITY
     pos_type seekpos(pos_type __sp,
----------------
This should be `_LIBCPP_HIDE_FROM_ABI_VIRTUAL`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141388/new/

https://reviews.llvm.org/D141388



More information about the libcxx-commits mailing list