[libcxx-commits] [PATCH] D140550: [String] Refactor unit tests to allow easy addition of new allocators

[Brendan Emery via Phabricator via libcxx-commits]

bemeryesr added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:112
+template <>
+TEST_CONSTEXPR_CXX20 void test_string<char, test_allocator>() {
+  using A  = test_allocator<char>;
----------------
ldionne wrote:
> We generally don't specialize function templates. This is a red flag to me. Why do we need this specialization?
I just added it since the test_allocator needs to be treated differently within the test (i.e. initialised with a value) and wanted to keep the calling code consistent. But I'll remove the function template specialization.


================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp:79
+  test(S("12345678901234567890"), 15, s, s + 10, S("123456789012345ABCDEFGHIJ67890"));
+  test(S("12345678901234567890"),
+       20,
----------------
ldionne wrote:
> Same comment about line breaks.
This change was just formatting so I've removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140550/new/

https://reviews.llvm.org/D140550