[libcxx-commits] [PATCH] D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D141222#4037293 <https://reviews.llvm.org/D141222#4037293>, @ldionne wrote:

> Oh actually I had created D131619 <https://reviews.llvm.org/D131619>, that's what I was looking for.

Looking at that patch again, I feel like the additional

  _LIBCPP_NORETURN _LIBCPP_HIDE_FROM_ABI inline
  void __exception_abort(char const* __file, int __line, char const* __msg) {
    std::__libcpp_verbose_abort("%s:%d: Exception thrown with exceptions disabled: %s\n", __file, __line, __msg);
  }

and

  _LIBCPP_NORETURN _LIBCPP_HIDE_FROM_ABI inline
  void __assertion_abort(char const* __file, int __line, char const* __expr, char const* __msg) {
    std::__libcpp_verbose_abort("%s:%d: Assertion %s failed: %s\n", __file, __line, __expr, __msg);
  }

did make sense, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141222/new/

https://reviews.llvm.org/D141222