[libcxx-commits] [PATCH] D141208: libc++: bring back the unsigned in the return type in wcstoull_l

Mon Jan 9 08:50:41 PST 2023

Mordante added a comment.

In D141208#4035242 <https://reviews.llvm.org/D141208#4035242>, @mgorny wrote:

>> Our policy is to not accept patches where nobody is willing to provide a CI bot, which is the case here currently.
>
> That "policy" is really against the principles of open source. Corporations have money to maintain CI bots. Small open source projects can't afford the huge cost of running CI for libc++.

I'm not aware we (libc++) have this policy. Per https://libcxx.llvm.org/

  If a platform or compiler is not listed here, it is not officially supported. It may happen to work, and in practice the library is known to work on some platforms not listed here, but we don’t make any guarantees. If you would like your compiler and/or platform to be formally supported and listed here, please work with the libc++ team to set up testing for your configuration.

So without a proper CI we can't officially support a configuration, so we love to have a CI. Some changes are heavily platform dependent which we can't test without a CI. That said, personally I've no objection at all for patches the improve support for the musl libc.

In D141208#4035450 <https://reviews.llvm.org/D141208#4035450>, @sylvestre.ledru wrote:

> @philnik Sorry but we don't really have a way to know who is the "libc++ team". I don't know if @brad is part of it or not

The libc++ team approves the blocked libc++ reviewer. I know requiring libc++ to approve can sound a bit pedantic, but in the past we had people approving ABI breaking changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141208/new/

https://reviews.llvm.org/D141208