[libcxx-commits] [PATCH] D141208: libc++: bring back the unsigned in the return type in wcstoull_l

Sun Jan 8 23:28:20 PST 2023

thesamesam added a comment.

In D141208#4034019 <https://reviews.llvm.org/D141208#4034019>, @philnik wrote:

> In D141208#4034013 <https://reviews.llvm.org/D141208#4034013>, @sylvestre.ledru wrote:
>
>> In D141208#4033997 <https://reviews.llvm.org/D141208#4033997>, @brad wrote:
>>
>>> Sorry about that.
>>
>> no worries ;)
>
> Please don't land libc++ patches unless approved by the libc++ team. I won't revert, but this code will be removed in the future unless we find someone who is willing to support the musl configuration in libc++. Our policy is to not accept patches where nobody is willing to provide a CI bot, which is the case here currently.

Could you show me where that policy is written? I wasn't aware of it.

This issue wasn't raised in D124227 <https://reviews.llvm.org/D124227> either.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141208/new/

https://reviews.llvm.org/D141208