[libcxx-commits] [PATCH] D141216: [libc++][test] zip_view test cleanups

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter requested review of this revision.
CaseyCarter added inline comments.


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.zip/types.h:305-325
 template <class Base = int*>
 struct common_input_iterator {
   Base it_;
 
   using value_type = int;
   using difference_type = std::intptr_t;
   using iterator_concept = std::input_iterator_tag;
----------------
philnik wrote:
> Maybe we should lift this into `test_iterators.h`. This seems like the kind of thing that gets duplicated very easily.
I'd prefer to land this as-is and leave any such code motion to a followup PR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141216/new/

https://reviews.llvm.org/D141216