[libcxx-commits] [PATCH] D141216: [libc++][test] zip_view test cleanups

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.zip/cpo.pass.cpp:66
 
+#ifdef _LIBCPP_VERSION // libc++ doesn't implement P2165R4 yet
     static_assert(std::is_same_v<std::ranges::range_reference_t<decltype(v2)>, std::tuple<std::pair<int&, int&>>>);
----------------
Maybe guard this on `defined(__cpp_lib_tuple_like) && __cpp_lib_tuple_like >= 202207L`?


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.zip/types.h:305-325
 template <class Base = int*>
 struct common_input_iterator {
   Base it_;
 
   using value_type = int;
   using difference_type = std::intptr_t;
   using iterator_concept = std::input_iterator_tag;
----------------
Maybe we should lift this into `test_iterators.h`. This seems like the kind of thing that gets duplicated very easily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141216/new/

https://reviews.llvm.org/D141216