[libcxx-commits] [PATCH] D140913: [In Progress] [libc++] make_unique[shared]_for_overwrite

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jan 7 04:36:08 PST 2023


Mordante added a comment.

I only skimmed over the patch, can you update the description what it exactly does.

FYI when you create a patch with `arc` you can use `--draft` to mark it as draft, then it will be tested by the CI but not show in the review queue.



================
Comment at: libcxx/include/memory:735
+template<class T, class A>
+  shared_ptr<T> allocate_shared_for_overwrite(const A& a, size_t N);          // T is U[], C++20
+
----------------
Does this complete P1020?
I think this completes P2273 (https://libcxx.llvm.org/Status/Cxx2b.html#id2)
can you update the status pages accordingly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140913/new/

https://reviews.llvm.org/D140913



More information about the libcxx-commits mailing list