[libcxx-commits] [PATCH] D140359: [ItaniumDemangle] Fix substitution failure of _BitInt

[Senran Zhang via Phabricator via libcxx-commits]

zsrkmyn added a comment.

I just noticed that `DF` isn't substituted by clang.

  $ echo 'void foo(_Float16 a, _Float16 b) {}' | ./clang -xc++ - -S -o - -emit-llvm | grep def
  define dso_local void @_Z3fooDF16_DF16_(half noundef %a, half noundef %b) #0 {

It would look good if we keep `_FloatN` and `_Bitint` are substituted (or not) in the same way no matter if we fix it in ABI doc or frontend.

I'd prefer fixing it in the ABI for the intent for shorter encoding. I can submit a fix in either clang or ABI if you like :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140359/new/

https://reviews.llvm.org/D140359