[libcxx-commits] [PATCH] D140359: [ItaniumDemangle] Fix substitution failure of _BitInt

[Aaron Ballman via Phabricator via libcxx-commits]

aaron.ballman added a reviewer: rjmccall.
aaron.ballman added a subscriber: rjmccall.
aaron.ballman added a comment.

Adding @rjmccall for Itanium ABI code owner opinions.



================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:3929-3930
         return nullptr;
-      return make<BitIntType>(Size, Signed);
+      Result = make<BitIntType>(Size, Signed);
+      break;
     }
----------------
The comments below say:
```
  // If we parsed a type, insert it into the substitution table. Note that all
  // <builtin-type>s and <substitution>s have already bailed out, because they
  // don't get substitutions.
```
`_BitInt` is a builtin type, so I don't think it should be in the substitution table, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140359/new/

https://reviews.llvm.org/D140359