[libcxx-commits] [PATCH] D140944: [libc++] Optimize _LIBCPP_HAS_NO_VERBOSE_ABORT_IN_LIBRARY

Tue Jan 3 19:43:48 PST 2023

vitalybuka added a comment.

In D140944#4024885 <https://reviews.llvm.org/D140944#4024885>, @philnik wrote:

> Could you provide some numbers? This doesn't look great, but I don't think we care that much about binary size with sanitizers. It's not great anyways, so it would have to be quite a big difference to make it worth adding `_LIBCPP_ALWAYS_INLINE`. Also, please add a comment why it is added. We don't do that everywhere we use the attribute currently, but we should. So let's not make it worse.

Actually at google we care about size with sanitizers.
server apps often close to 2GB of linker memory model limit
mobile always care about size

With asan+ubsan combo _LIBCPP_ENABLE_ASSERTIONS=1 costs us 1.6%
with this patch it's just 0.2%

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140944/new/

https://reviews.llvm.org/D140944