[libcxx-commits] [PATCH] D140944: [libc++] Optimize _LIBCPP_HAS_NO_VERBOSE_ABORT_IN_LIBRARY

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka created this revision.
Herald added a project: All.
vitalybuka requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Sanitizers, e.g. ubsan can uninline this call.
https://godbolt.org/z/s51sfezb5

This prevents discard of printf attributes and bloat binaries.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140944

Files:
  libcxx/include/__verbose_abort


Index: libcxx/include/__verbose_abort
===================================================================
--- libcxx/include/__verbose_abort
+++ libcxx/include/__verbose_abort
@@ -29,7 +29,7 @@
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
-_LIBCPP_NORETURN _LIBCPP_ATTRIBUTE_FORMAT(__printf__, 1, 2) _LIBCPP_HIDE_FROM_ABI inline
+_LIBCPP_NORETURN _LIBCPP_ALWAYS_INLINE _LIBCPP_ATTRIBUTE_FORMAT(__printf__, 1, 2) _LIBCPP_HIDE_FROM_ABI inline
 void __libcpp_verbose_abort(const char *, ...) {
   ::abort();
   __builtin_unreachable(); // never reached, but needed to tell the compiler that the function never returns


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140944.486147.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230104/f5ad369a/attachment.bin>