[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

Vlad Vereschaka via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 28 20:34:44 PST 2023


vvereschaka added a comment.

> Unfortunately I don't think I can really try to fix it without having access to some hardware. If you could give me access to a machine I'd be happy to work on fixing this.

Sorry, I can't give an access currently. But the problem is clear - this is a handling of the windows-style pathes by the current test. `lit` and `clang` handle them correctly, but when you switch to the unix tool (such as `bash`) on Windows, these tools do not work properly with that kind of pathes. They process the `\x` characters within the windows-style path as the control sequences and break the original path.  The test became too bash specific/depended and now it needs a proper processing/converting the pathes (`\` -> `/`) to work correctly on Windows hosts. `sed -e s/\\/\//g` on `%s` may help may be, but anyway it doesn't look portable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640



More information about the libcxx-commits mailing list