[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

Tue Feb 28 17:40:04 PST 2023

vvereschaka added a comment.

@philnik,

> Since this is isn't a libc++-supported configuration AFAICT and reverting the patch would break our own CI, I don't think that's an option.

This is supported libc++ configuration.

> I'm not actually sure why the test runs at all, since it looks like you are running a windows-arm build, which should be disabled by the // UNSUPPORTED: windows.

Because the target is Arm/Aarch64 Linux. This is Window-to-ARM-Linux cross builders.  `// UNSUPPORTED: windows` works for the Windows targets.

So, the test became broken on the windows cross builders. I'm going to disable it there for awhile.

@ldionne,

> @vvereschaka I think your issue with escaping should indeed be solved by https://reviews.llvm.org/D144825.

Unfortunately it wasn't solved.

> I suspect you ran into this issue because your executor (which must be some flavor of libcxx/utils/ssh.py must treat escapes differently.

I use libcxx's (libcxx/utils/ssh.py) executor to run the remote tests. The problem occurs on the build host side during the test preparations, before invoking `ssh.py`.

> Could you work with us on transitioning your build bot over to BuildKite so we run it as pre-commit?

I'll think, I'll try to find some hardware for that purpose. But currently there is no possibility to convert the existing cross builders into the buildkite agents.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640