[libcxx-commits] [PATCH] D142993: [libcxx] Add _LIBCPP_NODEBUG to global std::ranges::__cpo variables

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 28 12:29:04 PST 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM since it makes the status quo better. I would suggest we make this change right now, and if we need to use a different approach to fix the expression evaluator in the future, then we can cross that bridge when we get to it. But as far as we're concerned right now, this seems to be a pure improvement over the status quo.

Can you please rebase onto `main`? Once this is merged, we will also want to cherry-pick onto `release/16.x`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142993/new/

https://reviews.llvm.org/D142993



More information about the libcxx-commits mailing list