[libcxx-commits] [PATCH] D144698: [libcxx] <experimental/simd> Removed original implementations and tests

Tue Feb 28 01:55:42 PST 2023

philnik added a comment.

In D144698#4157370 <https://reviews.llvm.org/D144698#4157370>, @Joy12138 wrote:

> In D144698#4150453 <https://reviews.llvm.org/D144698#4150453>, @philnik wrote:
>
>> You have to remove `libcxx/include/experimental/simd` from `ignore_format.txt` to fix the CI.
>
> Then when should I put it back? Is it the next patch?

Never. We want to enforce the formatting. BTW you can use `ninja libcxx-generate-files` to update the generated files.

================
Comment at: libcxx/include/experimental/simd:653
-
-#include <__assert> // all public C++ headers provide the assertion handler
-#include <__functional/operations.h>
----------------
You have to keep this include to make the CI happy. Then you don't have to change anything in `generate_header_tests.py` (or the generated tests).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144698/new/

https://reviews.llvm.org/D144698