[libcxx-commits] [PATCH] D144821: [libc++][spaceship] Implement `operator<=>` for `deque`

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added a reviewer: Mordante.
avogelsgesang added a subscriber: Mordante.
avogelsgesang added a comment.

Thanks for this change!

In general, I won't be able to approve your commit for the `libc++` group. In the end, you will need the review from one of the "core libc++ contributors" (e.g., @Mordante) to ship this fix.

Also, for "stacked commits", i.e. commits which depend on other changes which didn't land on `main`, yet, you need to add a parent revision here on Phabricator. I did this for you already and also restarted the CI job. So this is just for future reference :)

Please also update `libcxx/docs/Status/SpaceshipProjects.csv`



================
Comment at: libcxx/include/deque:2398
+{
+    return lexicographical_compare_three_way(
+        __x.begin(), __x.end(), __y.begin(), __y.end(), __synth_three_way);
----------------
We need to ADL-proof this. My other commit for `std::list` was actually also missing this. A clang-tidy check in our CI should catch this and report an error for this line...


================
Comment at: libcxx/test/libcxx/containers/sequences/deque/compare.three_way.pass.cpp:26
+}
\ No newline at end of file

----------------
missing newline at end of file

(I assume you are on Windows? In case you are using VS Code, there is an "Insert Final Newline" setting which you might want to change)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144821/new/

https://reviews.llvm.org/D144821