[libcxx-commits] [PATCH] D144275: [libc++][format] Addresses LWG3810.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/format_args.h:76
+template <class _Context, class... _Args>
+basic_format_args(__format_arg_store<_Context, _Args...>) -> basic_format_args<_Context>;
 
----------------
ldionne wrote:
> Mordante wrote:
> > philnik wrote:
> > > Mordante wrote:
> > > > philnik wrote:
> > > > > Was there no test for the CTAD support before?
> > > > No that is the "silence the compiler when we want implicit CTAD" version. We don't have tests for these.
> > > I was asked by Louis to add one for the one I added for `move_iterator`(?). Weird that we don't have tests for all of them.
> > The original CTAD was added in D133535, but no test. I see some implicit CTAD tests added in that revision.
> > @ldionne should these test have been added for all types with the CTAD macro?
> Yes, tests should have been added in D133535 for all public types where I added the `_LIBCPP_CTAD_SUPPORTED_FOR_TYPE` macro. I just checked and it seems like I only missed this one, all the other ones seem to have tests.
Thanks, it seems the LWG issue was very useful ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144275/new/

https://reviews.llvm.org/D144275