[libcxx-commits] [PATCH] D144734: [libcxx] Enable support for static and debug Windows runtimes

[Andrew Ng via Phabricator via libcxx-commits]

andrewng added a comment.

> I tested my patch locally in all 6 combinations, i.e. including release and debug runtimes. However, it's already clear that the configuration that I've been using does not match CI. Now that there are CI failures, I should hopefully be able to find out the differences in configuration.

OK, having looked at the CI failures, I think I've identified the key configuration differences. CI disables `int128` support with `-DLIBCXX_EXTRA_SITE_DEFINES=_LIBCPP_HAS_NO_INT128` and `c++experimental` is disabled in the testing with `-DLIBCXX_TEST_PARAMS=enable_experimental=False`. I think this would explain the differences that I saw with test failures when testing my patch. Unfortunately, I was not aware that these features are unsupported on Windows.

So should I revise this patch with these configuration modifications? I suspect that this should result in significant simplification. Or should I wait until after the move to CMake 3.20?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144734/new/

https://reviews.llvm.org/D144734