[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D144640#4151286 <https://reviews.llvm.org/D144640#4151286>, @vvereschaka wrote:

> Hi @philnik,
>
> here is a problem with the test during the remote runs on the windows cross builders. A lot of those messages because of broken path:
>
>   clang++: error: no such file or directory: 'C:buildbotas-builder-1x-armv7lllvm-projectlibcxxtestlibcxxmodules_include.sh.cpp'
>   clang++: error: no input files
>   ...
>
> - https://lab.llvm.org/buildbot/#/builders/60/builds/10870/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__modules_include_s
> - https://lab.llvm.org/buildbot/#/builders/119/builds/12143/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__modules_include_s
>
> This is the windows to arm-linux cross builders, which run the tests on the arm/aarch64 boards.
>
> Would you fix that or revert the changes?

Since this is isn't a libc++-supported configuration AFAICT and reverting the patch would break our own CI, I don't think that's an option. I'm not actually sure why the test runs at all, since it looks like you are running a windows-arm build, which should be disabled by the `// UNSUPPORTED: windows`. It might be enough to drop the `bash -c` to avoid making the backslashes escape sequences. I can't remember why I used the in the first place, since I just use `echo` directly in other places. I'll make a patch to simplify this.



================
Comment at: libcxx/test/libcxx/modules_include.sh.cpp:40
+  print("// {}: bash -c 'echo \"TEST_{}=\\$!\"' >> %t.sh".format('RUN', i))
+  if i >= 16:
+    print("// {}: echo \"wait $TEST_{}\" >> %t.sh".format('RUN', i - 16))
----------------
Mordante wrote:
> Can you limit this to the number of cores on the system, for example, by using `nproc`? 
I'm not sure how I would do that without building a thread pool. Just the number of cores doesn't really help. At that point it's probably easier to integrate with lit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640