[libcxx-commits] [PATCH] D132312: [libc++][spaceship] Implement `operator<=>` for `list`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM after the CI is green.



================
Comment at: libcxx/test/support/test_container_comparisons.h:78
+
+  return true;
+}
----------------
avogelsgesang wrote:
> Mordante wrote:
> > I think these tests can be extended a bit, it feels like they now use a small number of types. I also miss tests for `<=` to be true/false for certain values.
> I am not sure I understand what you are asking for here
> 
> > use a small number of types
> 
> which additional types would you like to see? Afaict, the test case covers enough types such that we have all comparison categories covered?
> 
> > I also miss tests for <= to be true/false for certain values.
> 
> `testOrder` calls `testComparisonsComplete` which also covers `<=`. Or am I misunderstanding your request for additional test coverage
I missed the types where `<=>` is synthesized, but it's there too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132312/new/

https://reviews.llvm.org/D132312