[libcxx-commits] [PATCH] D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 25 06:39:11 PST 2023


Mordante added inline comments.


================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.members/swap.pass.cpp:27
+        sm1.first   = s1;
+        sm1.second  = s1+3;
+        sm1.matched = true;
----------------
fsb4000 wrote:
> Mordante wrote:
> > please use clang-format for this new file.
> Is clang-format-15 ok?
> 
> I see that clang-format-16 is used but I only have  clang-format-15.
Yes that's fine. They should behave the same for this file. We use a newer version for better formatting of C++20 features like concepts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144629/new/

https://reviews.llvm.org/D144629



More information about the libcxx-commits mailing list