[libcxx-commits] [PATCH] D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some nits.



================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.members/swap.pass.cpp:22-23
+    {
+        typedef char CharT;
+        typedef std::sub_match<const CharT*> SM;
+        const CharT s1[] = {'1', '2', '3', 0};
----------------
This is our new style preference, the same for `wchar_t`.


================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.members/swap.pass.cpp:27
+        sm1.first   = s1;
+        sm1.second  = s1+3;
+        sm1.matched = true;
----------------
please use clang-format for this new file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144629/new/

https://reviews.llvm.org/D144629