[libcxx-commits] [PATCH] D144580: [libc++] Inline small constructors into basic_string

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general I like this. Did you see a change in binary size or performance with this change?



================
Comment at: libcxx/include/string:995
+                          int> = 0>
   _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS _LIBCPP_CONSTEXPR_SINCE_CXX20
+  basic_string(const _Tp& __t, size_type __pos, size_type __n, const allocator_type& __a = allocator_type())
----------------
Has this change an effect due to the `_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS`?


================
Comment at: libcxx/include/string:1056
 
-    inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string();
+  inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() {
+    std::__debug_db_erase_c(this);
----------------
This changes the indention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144580/new/

https://reviews.llvm.org/D144580