[libcxx-commits] [PATCH] D112869: [libc++] Implement P2186R2 (Remove Garbage Collection)

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D112869#4152409 <https://reviews.llvm.org/D112869#4152409>, @Pawday wrote:

> In D112869#4152384 <https://reviews.llvm.org/D112869#4152384>, @philnik wrote:
>
>> In D112869#4152335 <https://reviews.llvm.org/D112869#4152335>, @Pawday wrote:
>>
>>> Why it doesn't rely on _LIBCPP_STD_VER?
>>
>> As discussed in the paper, there is no known implementation of the strict pointer safety facilities, which means that every use of this is a no-op, and therefore probably wrong. Pretty much the only code you can find is inside tests or a standard library: https://sourcegraph.com/search?q=context:global+declare_reachable+file:%5C.cpp+-file:en%5C.cppreference%5C.com+-file:declare_reachable%5C.pass%5C.cpp+-file:memory%5C.cpp+-file:legacy_pointer_safety%5C.cpp&patternType=standard&sm=1&groupBy=repo
>
> Does this mean if i set my compiler to -std=c++14 for example, and will include "memory" i would not get the full c++ 14 support (with std::declare_reachable for example)?

Technically yes, but I don't think anybody cares.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112869/new/

https://reviews.llvm.org/D112869