[libcxx-commits] [PATCH] D132769: [2b/3][ASan][libcxx] std::basic_string annotations

[Tacet via Phabricator via libcxx-commits]

AdvenamTacet marked an inline comment as done.
AdvenamTacet added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.asan/append.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
philnik wrote:
> These tests are very libc++-specific, so we should just put them in `test/libcxx/string/basic.string` and then have one test per overload. I know this is quite a bit of refactoring work, but it makes verifying the tests and figuring out what is broken a lot easier when it's necessary. You can just mirror the naming inside `test/std` and add a `.asan` in-between, i.e. `std/.../string_append/initalizer_list.pass.cpp` would become `libcxx/.../string_append/initializer_list.asan.pass.cpp`.
> 
> I didn't take a super close look at the tests yet, but other than splitting them up they look quite good.
I mostly removed my tests and merged them with already existing tests. In just few cases I saw a value in leaving `.asan.` file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132769/new/

https://reviews.llvm.org/D132769