[libcxx-commits] [PATCH] D144322: [libc++][Modules] Make top level modules for all C++ headers with OS/clang versions

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 24 14:48:43 PST 2023


iana added a comment.

In D144322#4151493 <https://reviews.llvm.org/D144322#4151493>, @vsapsai wrote:

> This is a pretty big change and there are no tests added. I haven't thought how and if these changes can be tested. Have you considered how the automated testing should be done?

There are a couple of module tests already that do a pretty good job of exercising the change. (They broke a bunch as I ported the original change from 15.x to 16.x to main, and as I rebased).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144322/new/

https://reviews.llvm.org/D144322



More information about the libcxx-commits mailing list