[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 24 08:37:12 PST 2023


Mordante added a comment.

In D144640#4148483 <https://reviews.llvm.org/D144640#4148483>, @philnik wrote:

> I'll land this now, since it fixes the CI and actually lets a lot of the runs be a lot faster. Feel free to review post-commit and I'll create a patch to address any comments.

I agree with our reasoning. I think it would be good for @ldionne to have a look.



================
Comment at: libcxx/test/libcxx/modules_include.sh.cpp:40
+  print("// {}: bash -c 'echo \"TEST_{}=\\$!\"' >> %t.sh".format('RUN', i))
+  if i >= 16:
+    print("// {}: echo \"wait $TEST_{}\" >> %t.sh".format('RUN', i - 16))
----------------
Can you limit this to the number of cores on the system, for example, by using `nproc`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640



More information about the libcxx-commits mailing list