[libcxx-commits] [PATCH] D144667: [libc++] Enable -Wunused-template

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 24 08:22:23 PST 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, please wait for D144737 <https://reviews.llvm.org/D144737> before landing this.



================
Comment at: libcxx/test/std/time/time.hms/time.hms.nonmembers/ostream.pass.cpp:56
 
-template <class CharT, class Duration>
-static std::basic_string<CharT> stream_ja_JP_locale(std::chrono::hh_mm_ss<Duration> hms) {
----------------
philnik wrote:
> @Mordante Did you forget to use this function while implementing the test?
Yes the good old copy paste bugs ;-) See D144737 for the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144667/new/

https://reviews.llvm.org/D144667



More information about the libcxx-commits mailing list