[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

Thu Feb 23 08:19:57 PST 2023

philnik added a comment.

Some numbers:

| Run           | Test old time | Test new time | all old time | all new time |
| C++2b         | 853s          | 55s           | 15m 33s      | 8m 58s       |
| Modular build | 763s          | 51s           | 14m 7s       | 13m 6s       |
| C++03         | 227s          | 14s           | 4m 54s       | 4m 7s        |
|

I have no idea what's going on on the windows runners. That's probably unrelated, since on windows the test is marked `UNSUPPORTED`. On Apple the test has a timeout now, probably because of resource contention, since this test starts ~140 processes in parallel now and they are much weaker than the Linux runners. I'll try to change the script to run at most 16 processes in parallel to avoid the contention. In a perfect world we'd use the lit thread pool for this, but that would require teaching lit about multiple independent processes from a single test file, which would take a lot longer than changing the script here. Let's fix the test first and then make it better.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640