[libcxx-commits] [PATCH] D144632: [libcxx] Split modules_include test to reduce overall runtime

David Spickett via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 23 03:08:04 PST 2023


DavidSpickett created this revision.
Herald added subscribers: kristof.beyls, arichardson.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This test was taking around 20-25 minutes to complete on Arm 32 bit.
https://reviews.llvm.org/D144259 appears to have increased that even
more which pushed us over the 25 minute timeout for CI.

Even on AArch64 the test took 18 minutes and it took 14 minutes on
the generic clang-15 bot.

I've split the test into 4 parts to bring it down to about 5 minutes
per test on Arm 32.

We could split it further but at that point we should be looking
at generating the whole set of files instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144632

Files:
  libcxx/test/libcxx/modules_include.sh.cpp
  libcxx/test/libcxx/modules_include_1.sh.cpp
  libcxx/test/libcxx/modules_include_2.sh.cpp
  libcxx/test/libcxx/modules_include_3.sh.cpp
  libcxx/test/libcxx/modules_include_4.sh.cpp
  libcxx/utils/generate_header_tests.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144632.499789.patch
Type: text/x-patch
Size: 62787 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230223/cd1ee9c9/attachment-0001.bin>


More information about the libcxx-commits mailing list