[libcxx-commits] [PATCH] D132769: [2b/3][ASan][libcxx] std::basic_string annotations

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 22 20:54:06 PST 2023


AdvenamTacet updated this revision to Diff 499718.
AdvenamTacet added a comment.

This update:

- adds support for annotating short strings with every allocator,
- removes special-casing (template) from `__annotate_*` interface, makes it simpler,
- cleans too aggressive style changes.

I believe, this patch and the prvious one, answers all points from the code review. If there is anything I should change, please, let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132769/new/

https://reviews.llvm.org/D132769

Files:
  libcxx/include/__string/extern_template_lists.h
  libcxx/include/string
  libcxx/test/std/strings/basic.string/string.asan/append.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/assign.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/capacity.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/concatenate.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/constructor.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/erase.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/insert.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/push_pop_back.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/replace.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/substr.pass.cpp
  libcxx/test/std/strings/basic.string/string.asan/swap.pass.cpp
  libcxx/test/support/asan_testing.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132769.499718.patch
Type: text/x-patch
Size: 143785 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230223/bc9764c3/attachment-0001.bin>


More information about the libcxx-commits mailing list