[libcxx-commits] [PATCH] D143914: [libc++] Clean up pair's constructors and assignment operators

[James Y Knight via Phabricator via libcxx-commits]

jyknight added a comment.

> however the fix in most cases should be to use -std=c++2b and the code will work out of the box.

It was unfortunate that libc++ shipped this extension in the first place, but given that it did, it seems a little weird to require all users to migrate away from using the long-standing extension, only to bring it (mostly) right back in C++23 mode.

I wonder if it'd make sense to keep the extension in earlier standards modes, but modified to have the C++23 requirements. I'm assuming that the differences between the previous "tuple-like" requirement and new "pair-like" requirement is likely to be irrelevant to the real-world usages -- maybe worth verifying that assumption?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143914/new/

https://reviews.llvm.org/D143914