[libcxx-commits] [PATCH] D144279: [libc++][format] Fixes formatting vector<bool>

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__bit_reference:158
 public:
+    using __container = typename _Cp::__self;
+
----------------
Mordante wrote:
> philnik wrote:
> > Why not just `_Cp`?
> To make sure this is used with a `std::vector`, similar to the friend at line 155.
How would it not be used with a `std::vector` or `std::bitset`? If a user tries to instantiate it with another class it's not exactly hard to add the alias.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144279/new/

https://reviews.llvm.org/D144279