[libcxx-commits] [PATCH] D141699: [libc++][ranges] Implement P2474R2(`views::repeat`).

[Yurong via Phabricator via libcxx-commits]

yronglin marked 2 inline comments as done.
yronglin added a comment.

@jloser Many thanks for your review!



================
Comment at: libcxx/include/__ranges/repeat_view.h:56
+    if constexpr (!same_as<_Bound, unreachable_sentinel_t>)
+      _LIBCPP_ASSERT(__bound_ >= 0, "The value of bound must greater equal than 0");
+  }
----------------
jloser wrote:
> **Quibble** "must be" instead of "must" may read slightly better. WDYT? Here and below.
Thanks, I agree with you, and applied your comments.


================
Comment at: libcxx/test/std/ranges/range.factories/range.repeat.view/end.pass.cpp:33
+    static_assert(std::same_as<decltype(rv.end()), std::unreachable_sentinel_t>);
+    //ASSERT_NOEXCEPT(rv.end());
+  }
----------------
jloser wrote:
> Should we uncomment this?
Thanks, removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141699/new/

https://reviews.llvm.org/D141699