[libcxx-commits] [PATCH] D143052: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added a comment.

I suspect this commit has broken the flang standalone build: https://lab.llvm.org/buildbot/#/builders/175/builds/25443

LLVMCheckCompilerLinkerFlag.cmake used to be present in the build dir, but is now not because it's in the top level cmake folder.

  Building Flang as a standalone project.
  CMake Error at /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/lib/cmake/llvm/HandleLLVMStdlib.cmake:16 (include):
    include could not find requested file:
      LLVMCheckLinkerFlag
  Call Stack (most recent call first):
    /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/lib/cmake/llvm/HandleLLVMOptions.cmake:11 (include)
    CMakeLists.txt:107 (include)

Is the intention that we handle this like `CMakePolicy.cmake` and pull it from the source dir when we build flang, or is it a mistake to move it to the top level?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143052/new/

https://reviews.llvm.org/D143052