[libcxx-commits] [PATCH] D143158: [libcxx][test] Cover RISC-V in string.capacity test

Wed Feb 22 06:52:43 PST 2023

asb added a comment.

In D143158#4115961 <https://reviews.llvm.org/D143158#4115961>, @philnik wrote:

> I'm not sure what exactly our requirements are on CI infrastructure, but I think for adding a new platform some compute resources have to be provided. I think the "existing infrastructure" note is mostly about general configurations, like a new C++ version, testing the unstable ABI and similar stuff. I'm not sure though. @ldionne should be able to give a definite answer here.

Hi @ldionne - just a ping for your thoughts here (and on your thoughts about native RISC-V precommit being slow).

I'd imagine the ideal case here for giving reasonable coverage without taking too long would be to cross-compile everything (all the compile-time tests would be covered here at least on the fast x86 host), and to run the tests that need executing using qemu-user-static. It looks like the linked Android test scripts are doing native x86_64 testing - is there an example in the current CI of a cross-build setup?

There's also the question of what such tests would run on. If you have existing infra that's open to adding new jobs, it definitely seems easiest if that can be used - and it reduces the risk of unwanted failures due to bot-specific issues. But I can explore spinning up something myself if necessary.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143158/new/

https://reviews.llvm.org/D143158