[libcxx-commits] [PATCH] D142817: [libc++] Addresses LWG3782.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % comment.



================
Comment at: libcxx/test/std/language.support/support.c.headers/support.c.headers.other/math.lerp.verify.cpp:27
+    ::lerp(f, f, f);    // expected-error {{no member named 'lerp' in the global namespace}}
+    std::lerp(f, f, f); // expected-error {{no member named 'lerp' in namespace 'std'}}
+  }
----------------
`<math.h>` is still allowed to include `<cmath>` (I think libstdc++ might do that), so this should be inside `test/libcxx` if we want to test it at all. Removing this should also fix the modules build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142817/new/

https://reviews.llvm.org/D142817