[libcxx-commits] [PATCH] D144261: [libc++] Add clang-tidy check for version checks
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 21 09:32:46 PST 2023
Mordante added a comment.
Are we running clang-tidy only on our headers or also on our test suite?
================
Comment at: libcxx/test/tools/clang_tidy_checks/CMakeLists.txt:6
-find_package(Clang 16...17)
+find_package(Clang 17)
----------------
This should be 16 for the CI. IIRC 17 is not installed by the CI.
I ran issues with this while testing locally with Clang-tidy, I am looking at the issue where `cmake` fails to run a second time and I have a solution, but I want to test a bit further before making a patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144261/new/
https://reviews.llvm.org/D144261
More information about the libcxx-commits
mailing list