[libcxx-commits] [PATCH] D144440: [runtimes][CMake] Drop the check to see if linker works

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 21 00:35:48 PST 2023


mstorsjo accepted this revision.
mstorsjo added a comment.

LGTM - I've also noticed that this no longer is necessary. And unifying the behaviour (so that the `--unwindlib=none` flag always gets passed, instead of only passing it in the rare cases of fully from-scratch builds with an incomplete toolchain) is certainly good.

However I'm quite curious about how this now works, when it didn't before. I'll see if I can manage to bisect down the change in behaviour...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144440/new/

https://reviews.llvm.org/D144440



More information about the libcxx-commits mailing list