[libcxx-commits] [PATCH] D144395: [runtimes] Move common functions from Handle{Libcxx, Libcxxabi, Libunwind}Flags.cmake to runtimes/cmake/Modules/HandleFlags.cmake

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 20 14:21:35 PST 2023


phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: libunwind/cmake/Modules/HandleLibunwindFlags.cmake:280-283
 # Turn a comma separated CMake list into a space separated string.
 macro(split_list listname)
   string(REPLACE ";" " " ${listname} "${${listname}}")
 endmacro()
----------------
This could be removed as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144395/new/

https://reviews.llvm.org/D144395



More information about the libcxx-commits mailing list